Skip to content

Commit 537c5f0

Browse files
Pankajpetersomogyi
authored andcommitted
HBASE-22930 Set unique name to longCompactions/shortCompactions/split threads (#585)
1 parent cb04c6c commit 537c5f0

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,7 @@ private void createSplitExcecutors() {
120120
final String n = Thread.currentThread().getName();
121121
int splitThreads = conf.getInt(SPLIT_THREADS, SPLIT_THREADS_DEFAULT);
122122
this.splits = (ThreadPoolExecutor) Executors.newFixedThreadPool(splitThreads,
123-
new ThreadFactoryBuilder().setNameFormat(n + "-splits-" + System.currentTimeMillis())
124-
.setDaemon(true).build());
123+
new ThreadFactoryBuilder().setNameFormat(n + "-splits-%d").setDaemon(true).build());
125124
}
126125

127126
private void createCompactionExecutors() {
@@ -138,18 +137,14 @@ private void createCompactionExecutors() {
138137
final String n = Thread.currentThread().getName();
139138

140139
StealJobQueue<Runnable> stealJobQueue = new StealJobQueue<Runnable>(COMPARATOR);
141-
this.longCompactions = new ThreadPoolExecutor(largeThreads, largeThreads, 60,
142-
TimeUnit.SECONDS, stealJobQueue,
143-
new ThreadFactoryBuilder()
144-
.setNameFormat(n + "-longCompactions-" + System.currentTimeMillis())
140+
this.longCompactions = new ThreadPoolExecutor(largeThreads, largeThreads, 60, TimeUnit.SECONDS,
141+
stealJobQueue, new ThreadFactoryBuilder().setNameFormat(n + "-longCompactions-%d")
145142
.setDaemon(true).build());
146143
this.longCompactions.setRejectedExecutionHandler(new Rejection());
147144
this.longCompactions.prestartAllCoreThreads();
148-
this.shortCompactions = new ThreadPoolExecutor(smallThreads, smallThreads, 60,
149-
TimeUnit.SECONDS, stealJobQueue.getStealFromQueue(),
150-
new ThreadFactoryBuilder()
151-
.setNameFormat(n + "-shortCompactions-" + System.currentTimeMillis())
152-
.setDaemon(true).build());
145+
this.shortCompactions = new ThreadPoolExecutor(smallThreads, smallThreads, 60, TimeUnit.SECONDS,
146+
stealJobQueue.getStealFromQueue(), new ThreadFactoryBuilder()
147+
.setNameFormat(n + "-shortCompactions-%d").setDaemon(true).build());
153148
this.shortCompactions.setRejectedExecutionHandler(new Rejection());
154149
}
155150

0 commit comments

Comments
 (0)