Skip to content

YARN-11634. Speed-up TestTimelineClient #6371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brumi1024 merged 1 commit into from
Dec 20, 2023
+4 −1
Merged

YARN-11634. Speed-up TestTimelineClient #6371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...p-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ public class TimelineConnector extends AbstractService {
private static final Joiner JOINER = Joiner.on("");
private static final Logger LOG =
LoggerFactory.getLogger(TimelineConnector.class);
public final static int DEFAULT_SOCKET_TIMEOUT = 1 * 60 * 1000; // 1 minute
@VisibleForTesting
public static int DEFAULT_SOCKET_TIMEOUT = 60_000; // 1 minute

private SSLFactory sslFactory;
Client client;
Expand Down
2 changes: 2 additions & 0 deletions ...-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ public void setup() {
conf.setBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED, true);
conf.setFloat(YarnConfiguration.TIMELINE_SERVICE_VERSION, 1.0f);
client = createTimelineClient(conf);
TimelineConnector.DEFAULT_SOCKET_TIMEOUT = 10;
Copy link
Member

@brumi1024 brumi1024 Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see a chance that test could fail due to a quite low socket timeout?

Copy link
Contributor Author

@K0K0V0K K0K0V0K Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well... it is a good question that made me wonder in case of a successful connection how long the KerberosAuthenticator#190 connect is running, and the plot-twist i just realized all of the tests expect timeout here 😅
If you add a some debug point before and after this line we can observe the debug point after the connect will never be triggered, so technically we can also write 1ms here, the tests can not be broken

Copy link
Member

@brumi1024 brumi1024 Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, in that case LGTM.

}

@AfterEach
Expand All @@ -88,6 +89,7 @@ public void tearDown() throws Exception {
if (isSSLConfigured()) {
KeyStoreTestUtil.cleanupSSLConfig(keystoresDir, sslConfDir);
}
TimelineConnector.DEFAULT_SOCKET_TIMEOUT = 60_000;
}

@Test
Expand Down