From 26b3148baaedef06c2e825cf989d01f3cf7bf3ab Mon Sep 17 00:00:00 2001 From: Swaminathan Balachandran Date: Mon, 20 Jun 2022 10:43:24 -0700 Subject: [PATCH 1/2] HADOOP-18306: Warnings should not be shown on cli console when linux user not present on client --- .../hadoop/security/ShellBasedUnixGroupsMapping.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java index f4db520ac24c0..447cf01bcf92f 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java @@ -215,7 +215,13 @@ private Set getUnixGroups(String user) throws IOException { groups = resolvePartialGroupNames(user, e.getMessage(), executor.getOutput()); } catch (PartialGroupNameException pge) { - LOG.warn("unable to return groups for user {}", user, pge); + if(LOG.isDebugEnabled()) { + LOG.debug("unable to return groups for user {}", user, pge); + } else { + LOG.warn("unable to return groups for user {}. " + + "Exception Class: {}, Exception Message: {}", + user, pge.getClass().getName(), pge.getMessage()); + } return EMPTY_GROUPS_SET; } } From 370df9b21f54462fd0da45aa1a5cf2c87bbd0757 Mon Sep 17 00:00:00 2001 From: Swaminathan Balachandran Date: Thu, 23 Jun 2022 11:35:15 -0700 Subject: [PATCH 2/2] HADOOP-18306: Address Review Comments --- .../hadoop/security/ShellBasedUnixGroupsMapping.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java index 447cf01bcf92f..d0c4e11cbefc3 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java @@ -215,13 +215,7 @@ private Set getUnixGroups(String user) throws IOException { groups = resolvePartialGroupNames(user, e.getMessage(), executor.getOutput()); } catch (PartialGroupNameException pge) { - if(LOG.isDebugEnabled()) { - LOG.debug("unable to return groups for user {}", user, pge); - } else { - LOG.warn("unable to return groups for user {}. " + - "Exception Class: {}, Exception Message: {}", - user, pge.getClass().getName(), pge.getMessage()); - } + LOG.debug("unable to return groups for user {}", user, pge); return EMPTY_GROUPS_SET; } }