Skip to content

HDFS-16507. [SBN read] Avoid purging edit log which is in progress #4082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunchao merged 2 commits into from
Mar 31, 2022
Merged

HDFS-16507. [SBN read] Avoid purging edit log which is in progress #4082

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e62e45b
HDFS-16507. Avoid purging edit log which is in progress
tomscut Mar 18, 2022
e24a429
use Preconditions.checkArgument instead of assert
tomscut Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...s-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1515,11 +1515,12 @@ public synchronized void purgeLogsOlderThan(final long minTxIdToKeep) {
if (!isOpenForWrite()) {
return;
}

assert curSegmentTxId == HdfsServerConstants.INVALID_TXID || // on format this is no-op
minTxIdToKeep <= curSegmentTxId :
"cannot purge logs older than txid " + minTxIdToKeep +
" when current segment starts at " + curSegmentTxId;

Preconditions.checkArgument(
curSegmentTxId == HdfsServerConstants.INVALID_TXID || // on format this is no-op
minTxIdToKeep <= curSegmentTxId,
"cannot purge logs older than txid " + minTxIdToKeep +
" when current segment starts at " + curSegmentTxId);
if (minTxIdToKeep == 0) {
return;
}
Expand Down