Skip to content

HDFS-16343. Add some debug logs when the dfsUsed are not used during Datanode startup. #3694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sodonnel merged 2 commits into from
Nov 23, 2021
Merged

HDFS-16343. Add some debug logs when the dfsUsed are not used during Datanode startup. #3694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6087fbb
HDFS-16343. Add some debug logs when the dfsUsed are not used during …
mukul1987 Nov 21, 2021
4e23c2e
fix checkstyle
mukul1987 Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions ...s/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,9 +293,13 @@ long loadDfsUsed() {
long mtime;
Scanner sc;

File duCacheFile = new File(currentDir, DU_CACHE_FILE);
try {
sc = new Scanner(new File(currentDir, DU_CACHE_FILE), "UTF-8");
sc = new Scanner(duCacheFile, "UTF-8");
} catch (FileNotFoundException fnfe) {
FsDatasetImpl.LOG.warn("{} file missing in {}, will proceed with Du " +
"for space computation calculation, ",
DU_CACHE_FILE, currentDir);
return -1;
}

Expand All @@ -304,21 +308,31 @@ long loadDfsUsed() {
if (sc.hasNextLong()) {
cachedDfsUsed = sc.nextLong();
} else {
FsDatasetImpl.LOG.warn("cachedDfsUsed not found in file:{}, will " +
"proceed with Du for space computation calculation, ",
duCacheFile);
return -1;
}
// Get the recorded mtime from the file.
if (sc.hasNextLong()) {
mtime = sc.nextLong();
} else {
FsDatasetImpl.LOG.warn("mtime not found in file:{}, will proceed" +
" with Du for space computation calculation, ", duCacheFile);
return -1;
}

long elapsedTime = timer.now() - mtime;
// Return the cached value if mtime is okay.
if (mtime > 0 && (timer.now() - mtime < cachedDfsUsedCheckTime)) {
if (mtime > 0 && (elapsedTime < cachedDfsUsedCheckTime)) {
FsDatasetImpl.LOG.info("Cached dfsUsed found for " + currentDir + ": " +
cachedDfsUsed);
return cachedDfsUsed;
}
FsDatasetImpl.LOG.warn("elapsed time:{} is greater than threshold:{}," +
" mtime:{} in file:{}, will proceed with Du for space" +
" computation calculation",
elapsedTime, cachedDfsUsedCheckTime, mtime, duCacheFile);
return -1;
} finally {
sc.close();
Expand Down