From 3b380dfe5c909f167202b64ea6abea8fbae2b736 Mon Sep 17 00:00:00 2001
From: Anoop Sam John <anoopsamjohn@gmail.com>
Date: Thu, 22 Jul 2021 09:33:21 +0530
Subject: [PATCH 1/2] Addendum HADOOP-17770 WASB : Support disabling buffered
 reads in positional reads - Added the invalid SpotBugs warning to
 findbugs-exclude.xml

---
 .../hadoop-azure/dev-support/findbugs-exclude.xml   | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml b/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml
index b750b8b91c79e..51204caf5e45c 100644
--- a/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml
+++ b/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml
@@ -83,4 +83,17 @@
     <Bug pattern="IS2_INCONSISTENT_SYNC" />
   </Match>
 
+  <!-- This field is instance of BlockBlobInputStream and read(long, byte[], int, int)
+  calls it's Super class method when 'fs.azure.block.blob.buffered.pread.disable'
+  is configured false. Super class FSInputStream's implementation is having
+  proper synchronization.
+  When 'fs.azure.block.blob.buffered.pread.disable' is true, we want a lock free
+  implementation of blob read. Here we don't use any of the InputStream's
+  shared resource (buffer) and also don't change any cursor position etc.  
+  So its safe to go with unsynchronized way of read. -->
+  <Match>
+    <Class name="org.apache.hadoop.fs.azure.NativeAzureFileSystem$NativeAzureFsInputStream" />
+    <Field name="in" />
+    <Bug pattern="IS2_INCONSISTENT_SYNC" />
+  </Match>
  </FindBugsFilter>

From d6304e06cbd41ec3c24a5cdea5dac82c3bb0128e Mon Sep 17 00:00:00 2001
From: Anoop Sam John <anoopsamjohn@gmail.com>
Date: Thu, 22 Jul 2021 10:38:01 +0530
Subject: [PATCH 2/2] Addendum HADOOP-17770 WASB : Support disabling buffered
 reads in positional reads - Added the invalid SpotBugs warning to
 findbugs-exclude.xml

---
 hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml b/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml
index 51204caf5e45c..fa6085faa55bb 100644
--- a/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml
+++ b/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml
@@ -89,7 +89,7 @@
   proper synchronization.
   When 'fs.azure.block.blob.buffered.pread.disable' is true, we want a lock free
   implementation of blob read. Here we don't use any of the InputStream's
-  shared resource (buffer) and also don't change any cursor position etc.  
+  shared resource (buffer) and also don't change any cursor position etc.
   So its safe to go with unsynchronized way of read. -->
   <Match>
     <Class name="org.apache.hadoop.fs.azure.NativeAzureFileSystem$NativeAzureFsInputStream" />