Skip to content

Commit c132a53

Browse files
Fixed assertionComparision failure by resolving xml path for 'name'
1 parent 9c621fc commit c132a53

File tree

2 files changed

+15
-5
lines changed
  • hadoop-mapreduce-project/hadoop-mapreduce-client

2 files changed

+15
-5
lines changed

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestAMWebServicesJobs.java

+8-3
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@
3232
import javax.ws.rs.core.MediaType;
3333
import javax.xml.parsers.DocumentBuilder;
3434
import javax.xml.parsers.DocumentBuilderFactory;
35+
import javax.xml.xpath.XPathFactory;
36+
import javax.xml.xpath.XPath;
37+
import javax.xml.xpath.XPathExpressionException;
3538

3639
import org.apache.hadoop.conf.Configuration;
3740
import org.apache.hadoop.http.JettyUtils;
@@ -483,10 +486,12 @@ public void verifyAMJob(JSONObject info, Job job) throws JSONException {
483486

484487
}
485488

486-
public void verifyAMJobXML(NodeList nodes, AppContext appContext) {
487-
489+
public void verifyAMJobXML(NodeList nodes, AppContext appContext) throws XPathExpressionException {
488490
assertEquals("incorrect number of elements", 1, nodes.getLength());
489491

492+
XPathFactory xPathfactory = XPathFactory.newInstance();
493+
XPath xpath = xPathfactory.newXPath();
494+
490495
for (int i = 0; i < nodes.getLength(); i++) {
491496
Element element = (Element) nodes.item(i);
492497

@@ -496,7 +501,7 @@ public void verifyAMJobXML(NodeList nodes, AppContext appContext) {
496501

497502
verifyAMJobGeneric(job, WebServicesTestUtils.getXmlString(element, "id"),
498503
WebServicesTestUtils.getXmlString(element, "user"),
499-
WebServicesTestUtils.getXmlString(element, "name"),
504+
xpath.evaluate("name", element),
500505
WebServicesTestUtils.getXmlString(element, "state"),
501506
WebServicesTestUtils.getXmlLong(element, "startTime"),
502507
WebServicesTestUtils.getXmlLong(element, "finishTime"),

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobs.java

+7-2
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@
3434
import javax.ws.rs.core.MediaType;
3535
import javax.xml.parsers.DocumentBuilder;
3636
import javax.xml.parsers.DocumentBuilderFactory;
37+
import javax.xml.xpath.XPathFactory;
38+
import javax.xml.xpath.XPath;
39+
import javax.xml.xpath.XPathExpressionException;
3740

3841
import com.google.inject.util.Providers;
3942
import org.apache.hadoop.conf.Configuration;
@@ -229,9 +232,11 @@ public void verifyHsJobPartialXML(NodeList nodes, MockHistoryContext appContext)
229232
}
230233
}
231234

232-
public void verifyHsJobXML(NodeList nodes, AppContext appContext) {
235+
public void verifyHsJobXML(NodeList nodes, AppContext appContext) throws XPathExpressionException {
233236

234237
assertEquals("incorrect number of elements", 1, nodes.getLength());
238+
XPathFactory xPathfactory = XPathFactory.newInstance();
239+
XPath xpath = xPathfactory.newXPath();
235240

236241
for (int i = 0; i < nodes.getLength(); i++) {
237242
Element element = (Element) nodes.item(i);
@@ -243,7 +248,7 @@ public void verifyHsJobXML(NodeList nodes, AppContext appContext) {
243248
VerifyJobsUtils.verifyHsJobGeneric(job,
244249
WebServicesTestUtils.getXmlString(element, "id"),
245250
WebServicesTestUtils.getXmlString(element, "user"),
246-
WebServicesTestUtils.getXmlString(element, "name"),
251+
xpath.evaluate("name", element),
247252
WebServicesTestUtils.getXmlString(element, "state"),
248253
WebServicesTestUtils.getXmlString(element, "queue"),
249254
WebServicesTestUtils.getXmlLong(element, "startTime"),

0 commit comments

Comments
 (0)