-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix][C++] Remove arrow header from GraphAr's header #229
[BugFix][C++] Remove arrow header from GraphAr's header #229
Conversation
hi, @Ziy1-Tan, this pull request needs your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have a little doubt. When arrow is not installed, cmake will automatically build from source code. So we can always guarantee that arrow is installed, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shared_ptr requires a full definition of the type, so the forward declaration does not work
the source-build arrow is just used by graphar and include by static library(not expose), it does not install to system, so when user use graphar, we should guarantee they can run with graphar without arrow installed. |
Actually, shared_ptr can work with forward declaration. |
This PR still need some refine, like revise the |
ea162e9
to
3d5b74b
Compare
Signed-off-by: acezen <[email protected]>
3d5b74b
to
003a64f
Compare
Proposed changes
commit-49685 has include arrow header into graphar' header which we should not do that. Because we can't assume that users's system installed arrow.
Types of changes
What types of changes does your code introduce to GraphAr?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Fixed #228