Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][C++] Remove arrow header from GraphAr's header #229

Merged

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Aug 28, 2023

Proposed changes

commit-49685 has include arrow header into graphar' header which we should not do that. Because we can't assume that users's system installed arrow.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed #228

@acezen acezen requested a review from lixueclaire August 28, 2023 06:59
@acezen
Copy link
Contributor Author

acezen commented Aug 28, 2023

hi, @Ziy1-Tan, this pull request needs your review

@acezen acezen changed the title [BugFix] Remove arrow header from GraphAr's headers [BugFix][C++ Remove arrow header from GraphAr's headers Aug 28, 2023
@acezen acezen changed the title [BugFix][C++ Remove arrow header from GraphAr's headers [BugFix][C++] Remove arrow header from GraphAr's headers Aug 28, 2023
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ziy1-Tan
Copy link
Contributor

Ziy1-Tan commented Aug 28, 2023

hi, @Ziy1-Tan, this pull request needs your review

I have a little doubt. When arrow is not installed, cmake will automatically build from source code. So we can always guarantee that arrow is installed, right?

Copy link
Contributor

@Ziy1-Tan Ziy1-Tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shared_ptr requires a full definition of the type, so the forward declaration does not work

@acezen
Copy link
Contributor Author

acezen commented Aug 29, 2023

hi, @Ziy1-Tan, this pull request needs your review

I have a little doubt. When arrow is not installed, cmake will automatically build from source code. So we can always guarantee that arrow is installed, right?

the source-build arrow is just used by graphar and include by static library(not expose), it does not install to system, so when user use graphar, we should guarantee they can run with graphar without arrow installed.

@acezen
Copy link
Contributor Author

acezen commented Aug 29, 2023

shared_ptr requires a full definition of the type, so the forward declaration does not work

Actually, shared_ptr can work with forward declaration.
https://stackoverflow.com/questions/16588075/forward-declarations-and-shared-ptr

@acezen
Copy link
Contributor Author

acezen commented Aug 29, 2023

This PR still need some refine, like revise the Expression as a real wrapper of arrow::Expression which not expose the arrow::Expression outside.

@acezen acezen changed the title [BugFix][C++] Remove arrow header from GraphAr's headers [BugFix][C++] Remove arrow header from GraphAr's header Aug 29, 2023
@acezen acezen force-pushed the 228-clear-arrow-headers-from-graphar-header branch from ea162e9 to 3d5b74b Compare August 29, 2023 12:19
@acezen acezen force-pushed the 228-clear-arrow-headers-from-graphar-header branch from 3d5b74b to 003a64f Compare August 29, 2023 12:20
@acezen acezen merged commit eb0f3d9 into apache:main Aug 29, 2023
@acezen acezen deleted the 228-clear-arrow-headers-from-graphar-header branch August 29, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: filesystem.h include the arrow/dataset/api.h, graphar headers should not include any arrow headers
3 participants