Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][C++] Fix next_chunk() of readers in the C++ library #137

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

lixueclaire
Copy link
Contributor

Proposed changes

When a vertex chunk has no edge, the next_chunk() function of readers for adj_list/adj_list_property may get errors since it reads a non-existing chunk.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

🎊 PR Preview 726a92d has been successfully built and deployed to https://alibaba-graphar-build-pr-137.surge.sh

🤖 By surge-preview

@lixueclaire lixueclaire requested a review from acezen April 17, 2023 09:59
Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lixueclaire lixueclaire changed the title [BugFix][C++] Fix next_chunk() of readers in the C++ libraray [BugFix][C++] Fix next_chunk() of readers in the C++ library Apr 18, 2023
@lixueclaire lixueclaire merged commit 551cc78 into apache:main Apr 18, 2023
@lixueclaire lixueclaire deleted the fix-reader branch April 18, 2023 01:25
@acezen acezen mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants