Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable arrow S3 support to support reading and writing file with S3/OSS #125

Merged
merged 17 commits into from
Apr 18, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Mar 28, 2023

Proposed changes

This change open the ARROW_S3 option of arrow to support reading and writing file with S3 or OSS.

  • revise the FileSystem construct from uri to adapt file and s3;
  • add test case to test reading data from s3;

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

#115

@github-actions
Copy link

github-actions bot commented Mar 28, 2023

🎊 PR Preview 19de831 has been successfully built and deployed to https://alibaba-graphar-build-pr-125.surge.sh

🤖 By surge-preview

@acezen acezen force-pushed the enable-read-from-s3 branch from afabb48 to 41efe40 Compare April 17, 2023 06:40
@acezen acezen requested a review from lixueclaire April 17, 2023 12:10
@acezen acezen changed the title [WIP] Enable read data from s3 Enable arrow S3 support to support reading and writing file with S3/OSS Apr 17, 2023
@acezen acezen requested a review from sighingnow April 17, 2023 12:20
@acezen acezen force-pushed the enable-read-from-s3 branch from 72a5557 to 186df5a Compare April 18, 2023 00:14
@acezen
Copy link
Contributor Author

acezen commented Apr 18, 2023

@lixueclaire any comment about the pull request?

Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants