-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable arrow S3 support to support reading and writing file with S3/OSS #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 PR Preview 19de831 has been successfully built and deployed to https://alibaba-graphar-build-pr-125.surge.sh 🤖 By surge-preview |
Fix Update
acezen
force-pushed
the
enable-read-from-s3
branch
from
April 17, 2023 06:40
afabb48
to
41efe40
Compare
acezen
changed the title
[WIP] Enable read data from s3
Enable arrow S3 support to support reading and writing file with S3/OSS
Apr 17, 2023
acezen
force-pushed
the
enable-read-from-s3
branch
from
April 18, 2023 00:14
72a5557
to
186df5a
Compare
sighingnow
approved these changes
Apr 18, 2023
@lixueclaire any comment about the pull request? |
lixueclaire
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change open the ARROW_S3 option of arrow to support reading and writing file with S3 or OSS.
FileSystem
construct from uri to adapt file and s3;Types of changes
What types of changes does your code introduce to GraphAr?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
#115