Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to arrow definitions to avoid conflicts #106

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

sighingnow
Copy link
Contributor

Proposed changes

This pull request addresses two bugs:

  • include_directories(BEFORE SYSTEM ${ARROW_INCLUDE_DIR}) will bring arrow_ep/include/... to gar's cmake dependency
  • Without a private prefix for arrow definitions, there would be conflicts when the external projects both requires arrow and gar (using add_subdirectory).

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@sighingnow sighingnow requested a review from acezen February 20, 2023 03:57
@github-actions
Copy link

github-actions bot commented Feb 20, 2023

🎊 PR Preview dbdb8b2 has been successfully built and deployed to https://alibaba-graphar-build-pr-106.surge.sh

🤖 By surge-preview

@sighingnow sighingnow merged commit d26d3b8 into apache:main Feb 20, 2023
@sighingnow sighingnow deleted the ht/cmake-arrow branch February 20, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant