Add support for sending proxy jvm args to Yarn AM and Containers #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekmjain
force-pushed
the
proxy-jvm-args-fix
branch
from
44394b4
to
70cab90
Compare
phet
reviewed
Nov 13, 2024
Comment on lines
245
to
250
| String proxyConfigValue = config.hasPath(GobblinYarnConfigurationKeys.YARN_APPLICATION_PROXY_JVM_ARGS) ? | ||
| config.getString(GobblinYarnConfigurationKeys.YARN_APPLICATION_PROXY_JVM_ARGS) : StringUtils.EMPTY; | ||
|
|
||
| //We get config value as emptyStringPlaceholder when the string is actually supposed to be empty | ||
| this.proxyJvmArgs = proxyConfigValue.contains(GobblinYarnConfigurationKeys.EMPTY_STRING_PLACEHOLDER) | ||
| ? StringUtils.EMPTY : proxyConfigValue; |
There was a problem hiding this comment.
as you set it to empty when !config.hasPath(GobblinYarnConfigurationKeys.YARN_APPLICATION_PROXY_JVM_ARGS), what does this placeholder allow that just leaving out the property (or setting it to empty) would not?
There was a problem hiding this comment.
We are getting this value in Azkaban job in case of an empty string.
abhishekmjain
force-pushed
the
proxy-jvm-args-fix
branch
from
70cab90
to
c31c64c
Compare
phet
reviewed
Nov 14, 2024
Comment on lines
+36
to
+37
| Map<String, String> inversePlaceholderMap = ImmutableBiMap.copyOf(Splitter.on(",").withKeyValueSeparator(":") | ||
| .split(convertedProperties.get(PLACEHOLDER_MAP_KEY).toString())).inverse(); |
There was a problem hiding this comment.
if the prop named PLACEHOLDER_MAP_KEY were not found, would it .split("null")?
There was a problem hiding this comment.
Nice catch. Handled it and added unit tests around it.
gobblin-utility/src/test/java/org/apache/gobblin/AzkabanLauncherUtilsTest.java
Outdated
Show resolved
Hide resolved
gobblin-utility/src/main/java/org/apache/gobblin/util/AzkabanLauncherUtils.java
Show resolved
Hide resolved
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnConfigurationKeys.java
Show resolved
Hide resolved
phet
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
It allows proxy jvm args to be sent to Yarn AM and Containers which are retrieved from a new property.
Added custom handling for emptyStringPlaceholder since that's the value of config getting passed when the string is actually emtpy.
Tests
Tested locally using test Azkaban project
Added relevant unit tests
Commits