Skip to content

Commit 64eb6e2

Browse files
committed
adding changes that was removed during rebase
1 parent 8a51f6c commit 64eb6e2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/YarnService.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import java.util.concurrent.atomic.AtomicLong;
3838
import java.util.stream.IntStream;
3939

40+
import org.apache.commons.lang.StringUtils;
4041
import org.apache.hadoop.conf.Configuration;
4142
import org.apache.hadoop.fs.FileStatus;
4243
import org.apache.hadoop.fs.FileSystem;
@@ -157,9 +158,8 @@ class YarnService extends AbstractIdleService {
157158
private final boolean containerHostAffinityEnabled;
158159

159160
private final int helixInstanceMaxRetries;
160-
161-
private final Optional<String> containerJvmArgs;
162161
private final String containerTimezone;
162+
private final String proxyJvmArgs;
163163

164164
@Getter(AccessLevel.PROTECTED)
165165
private volatile Optional<Resource> maxResourceCapacity = Optional.absent();
@@ -242,9 +242,8 @@ public YarnService(Config config, String applicationName, String applicationId,
242242
this.helixInstanceTags = ConfigUtils.getString(config,
243243
GobblinClusterConfigurationKeys.HELIX_INSTANCE_TAGS_KEY, GobblinClusterConfigurationKeys.HELIX_DEFAULT_TAG);
244244

245-
this.containerJvmArgs = config.hasPath(GobblinYarnConfigurationKeys.CONTAINER_JVM_ARGS_KEY) ?
246-
Optional.of(config.getString(GobblinYarnConfigurationKeys.CONTAINER_JVM_ARGS_KEY)) :
247-
Optional.<String>absent();
245+
this.proxyJvmArgs = config.hasPath(GobblinYarnConfigurationKeys.YARN_APPLICATION_PROXY_JVM_ARGS) ?
246+
config.getString(GobblinYarnConfigurationKeys.YARN_APPLICATION_PROXY_JVM_ARGS) : StringUtils.EMPTY;
248247

249248
int numContainerLaunchThreads =
250249
ConfigUtils.getInt(config, GobblinYarnConfigurationKeys.MAX_CONTAINER_LAUNCH_THREADS_KEY,
@@ -621,6 +620,7 @@ protected String buildContainerCommand(Container container, String helixParticip
621620
.append(" -D").append(GobblinYarnConfigurationKeys.GOBBLIN_YARN_CONTAINER_LOG_DIR_NAME).append("=").append(ApplicationConstants.LOG_DIR_EXPANSION_VAR)
622621
.append(" -D").append(GobblinYarnConfigurationKeys.GOBBLIN_YARN_CONTAINER_LOG_FILE_NAME).append("=").append(containerProcessName).append(".").append(ApplicationConstants.STDOUT)
623622
.append(" ").append(JvmUtils.formatJvmArguments(workerJvmArgs))
623+
.append(" ").append(this.proxyJvmArgs)
624624
.append(" ").append(GobblinTemporalYarnTaskRunner.class.getName())
625625
.append(" --").append(GobblinClusterConfigurationKeys.APPLICATION_NAME_OPTION_NAME)
626626
.append(" ").append(this.applicationName)

0 commit comments

Comments
 (0)