Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo.registry.simplified=true and the register config won't take effect #4341

Closed
imsunv opened this issue Jun 18, 2019 · 0 comments · Fixed by #4397
Closed

dubbo.registry.simplified=true and the register config won't take effect #4341

imsunv opened this issue Jun 18, 2019 · 0 comments · Fixed by #4397
Assignees
Milestone

Comments

@imsunv
Copy link
Contributor

imsunv commented Jun 18, 2019

Steps to reproduce this issue

dubbo.registry.simplified=true 
<dubbo:service interface="org.apache.dubbo.demo.DemoService" register="false" ref="demoService" delay="5000"/>

when set dubbo.registry.simplified true. the dubbo.service.register won't take effect because of the register key was simplified and will use default value true;

URL providerUrl = getProviderUrl(originInvoker);
...
final URL registeredProviderUrl = getRegisteredProviderUrl(providerUrl, registryUrl);
boolean register = registeredProviderUrl.getParameter("register", true);

may use providerUrl here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants