-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-2.7.2] fix registery urls increase forever when recreate reference proxy #4109
Conversation
513b321
to
87f6a46
Compare
87f6a46
to
133078a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4109 +/- ##
============================================
+ Coverage 62.63% 62.68% +0.04%
- Complexity 543 545 +2
============================================
Files 762 762
Lines 32752 32753 +1
Branches 5162 5162
============================================
+ Hits 20515 20530 +15
+ Misses 9876 9862 -14
Partials 2361 2361
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this line will change the logic of urls, we will lose contents of urls
every time calling createProxy method . I believe it's not a good way to prevent infinite retries and OOM.
How do u think?
this urls
I think this createProxy() is a method to get a new client. It happended when last getProxy() failed and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
fix issue #4107
What is the purpose of the change
when client retry init reference, clear registry urls to avoid OOM.
the registry url contains timestamp value, it can not change urls from list to set.
Brief changelog
do clear urls when in create remote proxy
Verifying this change
do clear urls when create remote proxy
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.