Skip to content

Commit c58053d

Browse files
authored
0.1.x (#333)
* Bug fix on test case * Polish #327 & #325 * Polish #321 * Polish #220 no program * Switch Yaml file * Update version to be 0.2.0 * Polish #218 * Update Documents * Fix the test case's bugs * Fix plugins' issues * Fix test-cases * Fix test cases * Fixes an issue on DubboMvcEndpoint * Polish: Fix a relaxed property name issue
1 parent fa7405a commit c58053d

File tree

4 files changed

+25
-24
lines changed

4 files changed

+25
-24
lines changed

dubbo-spring-boot-autoconfigure/src/main/java/com/alibaba/boot/dubbo/autoconfigure/DubboAutoConfiguration.java

+5-3
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@
4040
import java.util.Set;
4141

4242
import static com.alibaba.boot.dubbo.util.DubboUtils.BASE_PACKAGES_PROPERTY_NAME;
43+
import static com.alibaba.boot.dubbo.util.DubboUtils.DUBBO_CONFIG_PREFIX;
4344
import static com.alibaba.boot.dubbo.util.DubboUtils.DUBBO_PREFIX;
45+
import static com.alibaba.boot.dubbo.util.DubboUtils.DUBBO_SCAN_PREFIX;
4446
import static com.alibaba.boot.dubbo.util.DubboUtils.MULTIPLE_CONFIG_PROPERTY_NAME;
4547
import static java.util.Collections.emptySet;
4648
import static org.springframework.beans.factory.config.ConfigurableBeanFactory.SCOPE_PROTOTYPE;
@@ -78,7 +80,7 @@ protected static class SingleDubboConfigConfiguration {
7880
* @see EnableDubboConfig
7981
* @see DubboConfigConfiguration.Multiple
8082
*/
81-
@ConditionalOnProperty(name = MULTIPLE_CONFIG_PROPERTY_NAME, havingValue = "true")
83+
@ConditionalOnProperty(prefix = DUBBO_CONFIG_PREFIX, name = MULTIPLE_CONFIG_PROPERTY_NAME, havingValue = "true")
8284
@EnableDubboConfig(multiple = true)
8385
protected static class MultipleDubboConfigConfiguration {
8486
}
@@ -89,11 +91,11 @@ protected static class MultipleDubboConfigConfiguration {
8991
* @param environment {@link Environment} Bean
9092
* @return {@link ServiceAnnotationBeanPostProcessor}
9193
*/
92-
@ConditionalOnProperty(name = BASE_PACKAGES_PROPERTY_NAME)
94+
@ConditionalOnProperty(prefix = DUBBO_SCAN_PREFIX, name = BASE_PACKAGES_PROPERTY_NAME)
9395
@ConditionalOnClass(RelaxedPropertyResolver.class)
9496
@Bean
9597
public ServiceAnnotationBeanPostProcessor serviceAnnotationBeanPostProcessor(Environment environment) {
96-
RelaxedPropertyResolver resolver = new RelaxedPropertyResolver(environment);
98+
RelaxedPropertyResolver resolver = new RelaxedPropertyResolver(environment, DUBBO_SCAN_PREFIX);
9799
Set<String> packagesToScan = resolver.getProperty(BASE_PACKAGES_PROPERTY_NAME, Set.class, emptySet());
98100
return new ServiceAnnotationBeanPostProcessor(packagesToScan);
99101
}

dubbo-spring-boot-autoconfigure/src/main/java/com/alibaba/boot/dubbo/context/event/OverrideDubboConfigApplicationListener.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.alibaba.boot.dubbo.context.event;
1818

1919
import com.alibaba.dubbo.common.utils.ConfigUtils;
20-
2120
import com.alibaba.dubbo.config.AbstractConfig;
2221

2322
import org.slf4j.Logger;
@@ -31,6 +30,7 @@
3130
import java.util.SortedMap;
3231

3332
import static com.alibaba.boot.dubbo.util.DubboUtils.DEFAULT_OVERRIDE_CONFIG_PROPERTY_VALUE;
33+
import static com.alibaba.boot.dubbo.util.DubboUtils.DUBBO_CONFIG_PREFIX;
3434
import static com.alibaba.boot.dubbo.util.DubboUtils.OVERRIDE_CONFIG_PROPERTY_NAME;
3535
import static com.alibaba.boot.dubbo.util.DubboUtils.filterDubboProperties;
3636

@@ -57,8 +57,8 @@ public void onApplicationEvent(ApplicationEnvironmentPreparedEvent event) {
5757

5858
ConfigurableEnvironment environment = event.getEnvironment();
5959

60-
boolean override = environment.getProperty(OVERRIDE_CONFIG_PROPERTY_NAME, boolean.class,
61-
DEFAULT_OVERRIDE_CONFIG_PROPERTY_VALUE);
60+
boolean override = environment.getProperty(DUBBO_CONFIG_PREFIX + OVERRIDE_CONFIG_PROPERTY_NAME,
61+
boolean.class, DEFAULT_OVERRIDE_CONFIG_PROPERTY_VALUE);
6262

6363
if (override) {
6464

dubbo-spring-boot-autoconfigure/src/main/java/com/alibaba/boot/dubbo/util/DubboUtils.java

+7-7
Original file line numberDiff line numberDiff line change
@@ -45,31 +45,31 @@ public abstract class DubboUtils {
4545
/**
4646
* The prefix of property name of Dubbo
4747
*/
48-
public static final String DUBBO_PREFIX = "dubbo";
48+
public static final String DUBBO_PREFIX = "dubbo" + PROPERTY_NAME_SEPARATOR;
4949

5050
/**
5151
* The prefix of property name for Dubbo scan
5252
*/
53-
public static final String DUBBO_SCAN_PREFIX = DUBBO_PREFIX + PROPERTY_NAME_SEPARATOR + "scan";
53+
public static final String DUBBO_SCAN_PREFIX = DUBBO_PREFIX + "scan" + PROPERTY_NAME_SEPARATOR;
5454

5555
/**
5656
* The prefix of property name for Dubbo Config.ØØ
5757
*/
58-
public static final String DUBBO_CONFIG_PREFIX = DUBBO_PREFIX + PROPERTY_NAME_SEPARATOR + "config";
58+
public static final String DUBBO_CONFIG_PREFIX = DUBBO_PREFIX + "config" + PROPERTY_NAME_SEPARATOR;
5959

6060
/**
6161
* The property name of base packages to scan
6262
* <p>
6363
* The default value is empty set.
6464
*/
65-
public static final String BASE_PACKAGES_PROPERTY_NAME = DUBBO_SCAN_PREFIX + PROPERTY_NAME_SEPARATOR + "base-packages";
65+
public static final String BASE_PACKAGES_PROPERTY_NAME = "base-packages";
6666

6767
/**
6868
* The property name of multiple properties binding from externalized configuration
6969
* <p>
7070
* The default value is {@link #DEFAULT_MULTIPLE_CONFIG_PROPERTY_VALUE}
7171
*/
72-
public static final String MULTIPLE_CONFIG_PROPERTY_NAME = DUBBO_CONFIG_PREFIX + PROPERTY_NAME_SEPARATOR + "multiple";
72+
public static final String MULTIPLE_CONFIG_PROPERTY_NAME = "multiple";
7373

7474
/**
7575
* The default value of multiple properties binding from externalized configuration
@@ -81,7 +81,7 @@ public abstract class DubboUtils {
8181
* <p>
8282
* The default value is {@link #DEFAULT_OVERRIDE_CONFIG_PROPERTY_VALUE}
8383
*/
84-
public static final String OVERRIDE_CONFIG_PROPERTY_NAME = DUBBO_CONFIG_PREFIX + PROPERTY_NAME_SEPARATOR + "override";
84+
public static final String OVERRIDE_CONFIG_PROPERTY_NAME = "override";
8585

8686
/**
8787
* The default property value of override Dubbo config
@@ -129,7 +129,7 @@ public static SortedMap<String, Object> filterDubboProperties(ConfigurableEnviro
129129
for (Map.Entry<String, Object> entry : properties.entrySet()) {
130130
String propertyName = entry.getKey();
131131

132-
if (propertyName.startsWith(DUBBO_PREFIX + PROPERTY_NAME_SEPARATOR)) {
132+
if (propertyName.startsWith(DUBBO_PREFIX)) {
133133
dubboProperties.put(propertyName, entry.getValue());
134134
}
135135

dubbo-spring-boot-autoconfigure/src/test/java/com/alibaba/boot/dubbo/util/DubboUtilsTest.java

+10-11
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939

4040
/**
4141
* {@link DubboUtils} Test
42-
4342
* @author <a href="mailto:[email protected]">Mercy</a>
4443
* @see DubboUtils
4544
* @since 1.0.0
@@ -49,17 +48,17 @@ public class DubboUtilsTest {
4948
@Test
5049
public void testConstants() {
5150

52-
Assert.assertEquals("dubbo", DUBBO_PREFIX);
51+
Assert.assertEquals("dubbo.", DUBBO_PREFIX);
5352

54-
Assert.assertEquals("dubbo.scan", DUBBO_SCAN_PREFIX);
53+
Assert.assertEquals("dubbo.scan.", DUBBO_SCAN_PREFIX);
5554

56-
Assert.assertEquals("dubbo.scan.base-packages", BASE_PACKAGES_PROPERTY_NAME);
55+
Assert.assertEquals("dubbo.scan.base-packages", DUBBO_SCAN_PREFIX + BASE_PACKAGES_PROPERTY_NAME);
5756

58-
Assert.assertEquals("dubbo.config", DUBBO_CONFIG_PREFIX);
57+
Assert.assertEquals("dubbo.config.", DUBBO_CONFIG_PREFIX);
5958

60-
Assert.assertEquals("dubbo.config.multiple", MULTIPLE_CONFIG_PROPERTY_NAME);
59+
Assert.assertEquals("dubbo.config.multiple", DUBBO_CONFIG_PREFIX + MULTIPLE_CONFIG_PROPERTY_NAME);
6160

62-
Assert.assertEquals("dubbo.config.override", OVERRIDE_CONFIG_PROPERTY_NAME);
61+
Assert.assertEquals("dubbo.config.override", DUBBO_CONFIG_PREFIX + OVERRIDE_CONFIG_PROPERTY_NAME);
6362

6463
Assert.assertEquals("https://github.com/apache/incubator-dubbo-spring-boot-project", DUBBO_SPRING_BOOT_GITHUB_URL);
6564
Assert.assertEquals("https://github.com/apache/incubator-dubbo-spring-boot-project.git", DUBBO_SPRING_BOOT_GIT_URL);
@@ -81,13 +80,13 @@ public void testFilterDubboProperties() {
8180

8281
MockEnvironment environment = new MockEnvironment();
8382
environment.setProperty("message", "Hello,World");
84-
environment.setProperty(MULTIPLE_CONFIG_PROPERTY_NAME, "true");
85-
environment.setProperty(OVERRIDE_CONFIG_PROPERTY_NAME, "true");
83+
environment.setProperty(DUBBO_CONFIG_PREFIX + MULTIPLE_CONFIG_PROPERTY_NAME, "true");
84+
environment.setProperty(DUBBO_CONFIG_PREFIX + OVERRIDE_CONFIG_PROPERTY_NAME, "true");
8685

8786
SortedMap<String, Object> dubboProperties = filterDubboProperties(environment);
8887

89-
Assert.assertEquals("true",dubboProperties.get(MULTIPLE_CONFIG_PROPERTY_NAME));
90-
Assert.assertEquals("true",dubboProperties.get(OVERRIDE_CONFIG_PROPERTY_NAME));
88+
Assert.assertEquals("true", dubboProperties.get(DUBBO_CONFIG_PREFIX + MULTIPLE_CONFIG_PROPERTY_NAME));
89+
Assert.assertEquals("true", dubboProperties.get(DUBBO_CONFIG_PREFIX + OVERRIDE_CONFIG_PROPERTY_NAME));
9190

9291
}
9392

0 commit comments

Comments
 (0)