Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubboctl: consider extracting the template dockerfile contents into separate files under a dir #35

Open
yin1999 opened this issue Sep 16, 2023 · 0 comments · May be fixed by #139
Open
Labels
dubboctl Command-line tool related

Comments

@yin1999
Copy link
Contributor

yin1999 commented Sep 16, 2023

The template dockerfile content is now placed in a go source file. Consider extracting the template dockerfile content into separate dockerfiles, like go.dockerfile, java.dockerfile, and using go:embed to embed dockerfile content as string variables in a index go source file.

By this way, we could get dockerfile highlighting feature provided by IDE and it will be easier to use tools to check the syntax and format the source file. It also makes it easier for us to support more runtimes, modify individual runtime configuration files, etc.

@mfordjody mfordjody added the dubboctl Command-line tool related label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dubboctl Command-line tool related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants