From 1e2679b9e5a056f6cba4a98b4bcb17045252ae3e Mon Sep 17 00:00:00 2001 From: yuez Date: Tue, 7 Jun 2022 17:27:31 +0800 Subject: [PATCH 1/2] fix: typo correction --- remoting/xds/error.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/remoting/xds/error.go b/remoting/xds/error.go index 2711cf7a79..29c899c9f1 100644 --- a/remoting/xds/error.go +++ b/remoting/xds/error.go @@ -22,6 +22,6 @@ import ( ) var ( - DiscoverLocalError = errors.New("Discovery local Pod's host from xds, failed please register service with endpoint to k8s ") + DiscoverLocalError = errors.New("Discovery local Pod's host from xds failed, please register service with endpoint to k8s ") DiscoverIstiodPodIpError = errors.New("Discovery istiod Pod's ip from xds failed, please register service with endpoint to k8s ") ) From 6c4d14bebb1019346dd351f5dbfa7874db395918 Mon Sep 17 00:00:00 2001 From: yuez Date: Wed, 8 Jun 2022 17:18:35 +0800 Subject: [PATCH 2/2] fix: replace magic string with constant --- config/reference_config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/reference_config.go b/config/reference_config.go index f370691b06..c53bc52424 100644 --- a/config/reference_config.go +++ b/config/reference_config.go @@ -192,7 +192,7 @@ func (rc *ReferenceConfig) Refer(srv interface{}) { invokers := make([]protocol.Invoker, len(rc.urls)) for i, u := range rc.urls { if u.Protocol == constant.ServiceRegistryProtocol { - invoker = extension.GetProtocol("registry").Refer(u) + invoker = extension.GetProtocol(constant.RegistryProtocol).Refer(u) } else { invoker = extension.GetProtocol(u.Protocol).Refer(u) }