Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Triple] Add XXX filter automatically when XXX is enabled #2505

Open
ev1lQuark opened this issue Nov 15, 2023 · 2 comments
Open

[Triple] Add XXX filter automatically when XXX is enabled #2505

ev1lQuark opened this issue Nov 15, 2023 · 2 comments

Comments

@ev1lQuark
Copy link
Contributor

Problem description

In the process of configuring and starting otel.tracing, set it according to the following configuration:

        ins, err := dubbo.NewInstance(
		dubbo.WithName("dubbo_sample_tracing"),
		dubbo.WithProtocol(
			protocol.WithTriple(),
			protocol.WithPort(20000),
		),
		dubbo.WithRegistry(
			registry.WithZookeeper(),
			registry.WithAddress("127.0.0.1:2181"),
		),
		dubbo.WithTracing(
			trace.WithEnabled(),
			trace.WithStdoutExporter(),
			trace.WithW3cPropagator(),
			trace.WithRatioMode(),
			trace.WithRatio(0.5),
		),
	)

But the otel tracing filter is not append to service.filter slice. So as the trace.WithEnabled() is correctly set by user, the otel.Tracing module is not working as expected.

Todo

During the startup process, if a module is enabled, the corresponding filter will be automatically added, allowing users to configure module enable logic easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants