diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0c5d3e0a7c..5ce1a142f9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,5 @@ **What this PR does**: diff --git a/protocol/protocolwrapper/protocol_filter_wrapper_test.go b/protocol/protocolwrapper/protocol_filter_wrapper_test.go index 842531ff8f..2400058e56 100644 --- a/protocol/protocolwrapper/protocol_filter_wrapper_test.go +++ b/protocol/protocolwrapper/protocol_filter_wrapper_test.go @@ -36,13 +36,15 @@ import ( "dubbo.apache.org/dubbo-go/v3/protocol" ) +const mockFilterKey = "mockEcho" + func TestProtocolFilterWrapperExport(t *testing.T) { filtProto := extension.GetProtocol(FILTER) filtProto.(*ProtocolFilterWrapper).protocol = &protocol.BaseProtocol{} u := common.NewURLWithOptions( common.WithParams(url.Values{}), - common.WithParamsValue(constant.SERVICE_FILTER_KEY, "echo ")) + common.WithParamsValue(constant.SERVICE_FILTER_KEY, mockFilterKey)) exporter := filtProto.Export(protocol.NewBaseInvoker(u)) _, ok := exporter.GetInvoker().(*FilterInvoker) assert.True(t, ok) @@ -54,15 +56,15 @@ func TestProtocolFilterWrapperRefer(t *testing.T) { u := common.NewURLWithOptions( common.WithParams(url.Values{}), - common.WithParamsValue(constant.REFERENCE_FILTER_KEY, " echo")) + common.WithParamsValue(constant.REFERENCE_FILTER_KEY, mockFilterKey)) invoker := filtProto.Refer(u) _, ok := invoker.(*FilterInvoker) assert.True(t, ok) } -// the same as echo filter, for test +// The initialization of mockEchoFilter, for test func init() { - extension.SetFilter("echo", newFilter) + extension.SetFilter(mockFilterKey, newFilter) } type mockEchoFilter struct{}