Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16272][Alert Server] Alarm server failed to send alarm #16275

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

wangbowen1024
Copy link
Contributor

Purpose of the pull request

close #16272
Fix Alarm server failed to send alarm

Cause analysis

because json Conversion exception.
like this script alert plugin:
image
and debug then get the json string:
image
then want to conversion to PluginParams.class:
image
but ,the PluginParams is not what we want, the params will Construct ScriptSender:
image
image
so, we just need to Conversion json to map

@SbloodyS SbloodyS added bug Something isn't working 3.2.2 labels Jul 5, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Jul 5, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Jul 5, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit b539942 into apache:dev Jul 5, 2024
66 of 68 checks passed
SbloodyS pushed a commit to SbloodyS/dolphinscheduler that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Alert Server] Alarm server failed to send alarm
3 participants