chore: improve RepartitionExec display tree #15606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getChan
changed the title
2010YOUY01
reviewed
Apr 7, 2025
| f, | ||
| "output_partition_count={}", | ||
| "input_partition_count={}", | ||
| self.input.output_partitioning().partition_count() |
Contributor
There was a problem hiding this comment.
I think the output partition number is required to display in this node, but it's not implemented correctly. (or maybe now the planner always set the output partition the same as the input partition count)
I suggest to change the implementation instead, maybe we can display both the input and output partition count.
Contributor
Author
There was a problem hiding this comment.
thanks for review.
The output partition number is already included in the partitioning_scheme, so it is displayed.
ex)
13)┌─────────────┴─────────────┐
14)│ RepartitionExec │
15)│ -------------------- │
16)│ input_partition_count: │
17)│ 1 │
18)│ │
19)│ partitioning_scheme: │
20)│ RoundRobinBatch(4) │
21)└─────────────┬─────────────┘
Contributor
There was a problem hiding this comment.
Maybe as a follow-up task we can update it to be more clear like
input_partition_count: 1
output_partition_count: 4
partition_scheme: RoundRobin
2010YOUY01
approved these changes
Apr 7, 2025
Contributor
2010YOUY01
left a comment
2010YOUY01
left a comment
There was a problem hiding this comment.
Makes sense, thank you.
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
* fix RepartitionExec tree displayformat * pass sqllogictests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
easy to understand because it means the number of
RepartitionExecinput's output partition numberWhat changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
explain tree displaying