Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate LogicalPlan tree node walking / rewriting code in one place #9994

Closed
alamb opened this issue Apr 8, 2024 · 0 comments · Fixed by #10034
Closed

Consolidate LogicalPlan tree node walking / rewriting code in one place #9994

alamb opened this issue Apr 8, 2024 · 0 comments · Fixed by #10034
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Apr 8, 2024

Is your feature request related to a problem or challenge?

One thing I noticed while working on #9913 with @peter-toth is that keeping track of all the LogicalPlan tree node walking / rewriting is somewhat hard for me (and datafusion/expr/src/logical_plan/plan.rs is getting pretty large).

Describe the solution you'd like

I would like to move all all the code into a single module where we could:

  1. Find it more easily
  2. Document the overall treenode walking / rewriting situation

Describe alternatives you've considered

(maybe alongside the impl TreeNode for LogicalPlan) ? Maybe somethign like datafusion/expr/src/logical_plan/tree_node.rs or datafusion/expr/src/logical_plan/apply_visit.rs 🤔

Additional context

See also #9913 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant