Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr.slt test failing in main #9891

Closed
Omega359 opened this issue Mar 31, 2024 · 4 comments · Fixed by #9894
Closed

expr.slt test failing in main #9891

Omega359 opened this issue Mar 31, 2024 · 4 comments · Fixed by #9894
Labels
bug Something isn't working

Comments

@Omega359
Copy link
Contributor

Omega359 commented Mar 31, 2024

Describe the bug

Running "expr.slt"
External error: query failed: DataFusion error: Schema error: No field named t2."struct(t1.time,t1.load1,t1.load2,t1.host)". Valid fields are t2."named_struct(Utf8(""c0""),t1.time,Utf8(""c1""),t1.load1,Utf8(""c2""),t1.load2,Utf8(""c3""),t1.host)".
[SQL] select t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] as host, sum(coalesce(t2."struct(t1.time,t1.load1,t1.load2,t1.host)")['c1']) from (select struct(time,load1,load2,host) from t1) t2 where t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] IS NOT NULL group by t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] order by host;
at test_files/expr.slt:2290

Seems to be related possibly to an interaction between #9743 and #9871. Seen in CI run on #9878 and locally.

To Reproduce

cargo test --test sqllogictests -- expr

Expected behavior

test passes

Additional context

No response

@jayzhan211
Copy link
Contributor

Why is the error not failed in CI previously 😕 It seems like a non-trivial fix, should we revert the commit in this case?

@alamb
Copy link
Contributor

alamb commented Apr 1, 2024

I agree with @Omega359 that this looks like a logical conflict with #9743

Specifically #9743 causes the column names to be different.

@alamb
Copy link
Contributor

alamb commented Apr 1, 2024

Specifically since #9743 changed the name of the columns, this test would have had to use the new names.

@alamb
Copy link
Contributor

alamb commented Apr 1, 2024

Thank you very much @Omega359 and @jayzhan211 -- sorry for the disruption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants