Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from_unixtime, now, current_date, current_time to datafusion-functions #9512

Open
Tangruilin opened this issue Mar 9, 2024 · 5 comments
Open

Move from_unixtime, now, current_date, current_time to datafusion-functions #9512

Tangruilin opened this issue Mar 9, 2024 · 5 comments
Assignees
@Tangruilin
Labels
enhancement New feature or request

Comments

@Tangruilin
Copy link
Contributor

Is your feature request related to a problem or challenge?

As part of #9285 the from_unixtime, now, current_date, current_time datetime functions should be migrated to the new datafusion-functions crate in the new structure

Describe the solution you'd like

Functions are migrated to the new crate and use the new patterns as described in #9286 & #9216,

Describe alternatives you've considered

No response

Additional context

No response
@Tangruilin Tangruilin added the enhancement New feature or request label Mar 9, 2024
@Tangruilin
Copy link
Contributor Author

take

@Tangruilin Tangruilin mentioned this issue Mar 9, 2024
Closed
@Omega359
Copy link
Contributor

Omega359 commented Mar 9, 2024

dup of #9466. I've been waiting for #9435 to be merged in before creating a pull request...

@Tangruilin
Copy link
Contributor Author

dup of #9466. I've been waiting for #9435 to be merged in before creating a pull request...

sorry... I see that now, but do you mind me finishing this PR?

@Tangruilin
Copy link
Contributor Author

dup of #9466. I've been waiting for #9435 to be merged in before creating a pull request...

sorry... I see that now, but do you mind me finishing this PR?

Or you can submit you PR and I will close my PR

@yyy1000
Copy link
Contributor

yyy1000 commented Mar 13, 2024

I think you can close this issue, done by #9537 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tangruilin Tangruilin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Omega359 @Tangruilin @yyy1000