Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Support converting Exprs and LogicalPlans --> SQL Strings #9494

Open
6 of 8 tasks
alamb opened this issue Mar 7, 2024 · 4 comments
Open
6 of 8 tasks

[EPIC] Support converting Exprs and LogicalPlans --> SQL Strings #9494

alamb opened this issue Mar 7, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@alamb alamb added the enhancement New feature or request label Mar 7, 2024
@devinjdangelo
Copy link
Contributor

I think that we now have a solid enough foundation on these tasks that it would be a good first issue for a new contributor (#9495 especially). An individual or small number of logical Exprs could be handled in a stand alone PR with a test or two. I think this project is a great way to get more familiar with DataFusion's core data structures and optimization algorithms without already having expertise in database internals.

@alamb
Copy link
Contributor Author

alamb commented Mar 19, 2024

@devinjdangelo do you think we should file explicit follow on tickets, or do you think the existing PRs / documentation is clear enough about the ask (for someone who has no experience with DataFusion)?

I can file tickets if you prefer

@devinjdangelo
Copy link
Contributor

devinjdangelo commented Mar 19, 2024

@alamb I don't think we should file a ticket for every remaining Expr variant, but we could edit the description of #9495 to list the remaining unimplemented variants and make clear that we are looking for help for anyone interested to implement even just 1 at a time in a PR + write a test.

Here is the remaining list:

  • InList
  • ScalarFunction
  • Between
  • Case
  • WindowFunction
  • Like
  • ScalarVariable
  • SimilarTo
  • Not
  • IsNotNull
  • IsTrue
  • IsFalse
  • IsUnknown
  • IsNotTrue
  • IsNotUnknown
  • Negative
  • GetIndexedField
  • TryCast
  • Sort
  • Exists
  • Wildcard
  • GroupingSet
  • Placeholder
  • OuterReferenceColumn
  • Unnest

@alamb
Copy link
Contributor Author

alamb commented Mar 21, 2024

@alamb I don't think we should file a ticket for every remaining Expr variant, but we could edit the description of #9495 to list the remaining unimplemented variants and make clear that we are looking for help for anyone interested to implement even just 1 at a time in a PR + write a test.

Thank yoU @devinjdangelo -- I filed #9726

@alamb alamb changed the title [EPIC] Collection of SQL to/from LogicalPlan/Expr tickets [EPIC] Support converting Exprs and LogicalPlans --> SQL Strings May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants