-
Notifications
You must be signed in to change notification settings - Fork 1.1k
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue using arrow_cast
in ORDER BY expressions
#9143
Comments
I would like to work on this one. |
I actually began something with this fix, not finish it yet. Let me know if you are really interested in this. I can hold the fix. |
I wanted to work on it as an exercise to also learn the internals, if there is a hurry to solve it then go for it, if not then I would be glad to work on this. |
Okay, I think this is not urgent. I will hold the fix. If you don't have time to work this anymore later, please let me know. I will continue on this. Thank you. |
Note another approach might be to help #8985 (which would allow us to remove the special case handling of |
@alamb suggested a solution in that PR but I am still trying to understand where the arrow_cast UDF should be implemented after that PR is merged. |
We are talking about the organization on #9100 -- I am sorry it is not yet fully finalized or written down @brayanjuls I would propose putting it in datafusion-functions/src/core. However, there is not yet an example of doing so, but I can prioritize doing it so you have an example to follow (or you can take a shot at it on your own, but there is a bit of macro magic that is necessary) |
I would prefer waiting for the examples as I have little experience creating rust declarative macros. |
Makes sense -- I will try and get a PR shortly |
Describe the bug
originally opened in GlareDB/glaredb#2597
It seems that
arrow_cast
's special handling makes it so that it errors out when using it in an ORDER BY exprTo Reproduce
Expected behavior
It should be functionally equivalent in this example to using
to_timestamp_seconds
Additional context
No response
The text was updated successfully, but these errors were encountered: