Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate datafusion benchmarks into dfbench #7052

Closed
7 of 8 tasks
alamb opened this issue Jul 21, 2023 · 1 comment
Closed
7 of 8 tasks

Consolidate datafusion benchmarks into dfbench #7052

alamb opened this issue Jul 21, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jul 21, 2023

Is your feature request related to a problem or challenge?

DataFusion currently has four different benchmark runners for comparing different versions of datafusion with itself, which have substantial overlap in their functionality and code

cargo run --release --bin nyctaxi
cargo run --release --bin h2o
cargo run --release --bin parquet
cargo run --release --bin tpch

I would like to add a 5th one (ClickBench) #6994 but would like to avoid copy/pasting yet again mostly the same thing

Describe the solution you'd like

Thus I propose a new consoidated binary dfbench run like this:

cargo run --release --bin benchmark -- nyctaxi
cargo run --release --bin benchmark -- h2o
cargo run --release --bin benchmark -- parquet
cargo run --release --bin benchmark -- tpch
cargo run --release --bin benchmark -- clickbench (I want to add this)

Describe alternatives you've considered

Follow the same pattern

Additional context

Task List

@alamb
Copy link
Contributor Author

alamb commented Aug 14, 2023

I have completed all the work I have planned for this epic -- consolidating h20.ai bench is tracked by #7209 so I am going to close this one as complete

@alamb alamb closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant