feat(unparser): adding alias for table scan filter in sql unparser #12453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrybugakov
approved these changes
Sep 13, 2024
goldmedal
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Thanks @Lordworms working on this. Overall looks good to me. Just leave some suggestions.
Comment on lines
699
to
703
| fn test_alias_pushdown() -> Result<()> { | ||
| let schema = Schema::new(vec![ | ||
| Field::new("id", DataType::Int64, false), | ||
| Field::new("age", DataType::Int64, false), | ||
| ]); |
There was a problem hiding this comment.
I'm not sure if adding the unparsing test here is appropriate. 🤔 Typically, we add unparse-related tests in datafusion/sql/tests/cases/plan_to_sql.rs
I left a disabled test for this issue in the previous PR #12158. I guess we can just enable it and remove this test.
datafusion/sql/src/unparser/plan.rs
Outdated
Comment on lines
601
to
605
| .reduce(|acc, expr_result| match (acc, expr_result) { | ||
| (Ok(acc_expr), Ok(expr)) => Ok(acc_expr.and(expr)), | ||
| (Err(e), _) | (_, Err(e)) => Err(e), | ||
| }) |
There was a problem hiding this comment.
We can simplify here like this
Suggested change
| .reduce(|acc, expr_result| match (acc, expr_result) { | |
| (Ok(acc_expr), Ok(expr)) => Ok(acc_expr.and(expr)), | |
| (Err(e), _) | (_, Err(e)) => Err(e), | |
| }) | |
| .reduce(|acc, expr_result| { | |
| acc.and_then(|acc_expr| { | |
| expr_result.map(|expr| acc_expr.and(expr)) | |
| }) | |
| }) |
|
I think @goldmedal 's comments are all great. Once those have been addressed this PR will be ready to go from my persective. Thank you @Lordworms @goldmedal and @dmitrybugakov |
alamb
changed the title
Lordworms
force-pushed
the
issue_12368
branch
from
3a63ca0
to
d744393
Compare
|
@goldmedal @alamb @dmitrybugakov Thanks for the review! |
alamb
changed the title
alamb
approved these changes
Sep 15, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12368
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?