fix interval units parsing #12448
Merged
fix interval units parsing #12448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
commented
Sep 12, 2024
Comment on lines
+600
to
+601
| # This is interpreted as "0 hours" with PostgreSQL, should be fixed with | ||
| query error DataFusion error: Arrow error: Parser error: Invalid input syntax for type interval: "5 day HOUR" |
There was a problem hiding this comment.
|
@alamb if this passes I believe it's ready to merge despite the very minor regression, overall it's way better than what went before. In particular expressions like |
alamb
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Thank you @samuelcolvin -- this looks like a great improvement to me. 🙏
|
This PR has a merge conflict now and it turns out there seems to have been a logical conflict with a few of the prior PRs that were merge. I will fix them in this PR
|
|
Thanks again @samuelcolvin |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #11271 (accidentally got closed by the companion PR apache/arrow-rs#6211).
Negative PR (at least by lines of Rust) 🎉 .
Rationale for this change
Use the much improved unit parsing logic now supported by arrow-rs, instead of a simple 'add "seconds"' hack
What changes are included in this PR?
Change interval expression parsing to use arrow-rs logic
Are these changes tested?
Yes
Are there any user-facing changes?
Improvements to
intervalexpression functionality.