Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize lower()/upper() string function with ASCII fast path #12365

Open
Tracked by #12306
2010YOUY01 opened this issue Sep 7, 2024 · 5 comments
Open
Tracked by #12306

Optimize lower()/upper() string function with ASCII fast path #12365

2010YOUY01 opened this issue Sep 7, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@2010YOUY01
Copy link
Contributor

Is your feature request related to a problem or challenge?

Part of #12306

#12306 has introduced the rationale for ASCII fast path in detail

This optimization has already been implemented on char_length() string function and got some performance improvement
(In PR #12356)

Describe the solution you'd like

Implement ASCII fast path for lower() and upper() function

Describe alternatives you've considered

No response

Additional context

No response

@2010YOUY01 2010YOUY01 added the enhancement New feature or request label Sep 7, 2024
@tshauck
Copy link
Contributor

tshauck commented Sep 7, 2024

take

@thinh2
Copy link
Contributor

thinh2 commented Sep 30, 2024

Hi @tshauck, are you working on this issue?

@tshauck
Copy link
Contributor

tshauck commented Oct 4, 2024

@thinh2 Sorry to leave you hanging. I got started but got busy. If you want to work on it, by all means.

@thinh2
Copy link
Contributor

thinh2 commented Oct 9, 2024

thanks @tshauck . Let me try to do it.

@Omega359
Copy link
Contributor

Omega359 commented Nov 8, 2024

Note that lower/upper likely already does this. See

if value_data.is_ascii() {
and
fn case_conversion_ascii_array<'a, O, F>(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants