Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Box from Sort #12207

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Remove Box from Sort #12207

merged 1 commit into from
Aug 30, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 28, 2024 •
edited
Loading

expr::Sort had Box<Expr> because Sort was also an expression (via
expr::Expr::Sort). This has been removed, obsoleting need to use a
Box.

Extracted from and based on #12177 to reduce PR scope

@findepi findepi marked this pull request as draft August 28, 2024 07:25
@github-actions github-actions bot added documentation Improvements or additions to documentation sql SQL Planner logical-expr Logical plan and expressions optimizer Optimizer rules core Core DataFusion crate substrait proto Related to proto crate functions labels Aug 28, 2024
@findepi
Remove Box from Sort
03d6167 
`expr::Sort` had `Box<Expr>` because Sort was also an expression (via
`expr::Expr::Sort`). This has been removed, obsoleting need to use a
`Box`.
@findepi findepi marked this pull request as ready for review August 29, 2024 15:57
@github-actions github-actions bot removed documentation Improvements or additions to documentation functions labels Aug 29, 2024
@findepi
Copy link
Member Author

findepi commented Aug 29, 2024

thanks again @crepererum for merging #12177
this PR is now rebased on current main and ready for review

crepererum
crepererum approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@crepererum crepererum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me.

@crepererum crepererum added the api change Changes the API exposed to users of the crate label Aug 29, 2024
@findepi findepi mentioned this pull request Aug 29, 2024
Draft
lewiszlw
lewiszlw approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@lewiszlw lewiszlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, thank you @findepi .

@lewiszlw lewiszlw merged commit 94d178e into apache:main Aug 30, 2024
25 checks passed
@findepi findepi deleted the findepi/remove-sort-box branch August 30, 2024 09:46
@findepi
Copy link
Member Author

findepi commented Aug 30, 2024

thank you @crepererum @lewiszlw for your reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crepererum crepererum crepererum approved these changes

@lewiszlw lewiszlw lewiszlw approved these changes

Assignees
No one assigned
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules proto Related to proto crate sql SQL Planner substrait
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @crepererum @lewiszlw