You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a part of performing this change, @jayzhan211 recommended to use min and max as a default name for the new UDFs rather than the lowercase. However, performing this change makes test fails because in several places we use MAX and MIN, for example:
I have not verified if MAX and MIN are the only UDF for which we use uppercase rather than lowercase. I personally prefer to have all SQL KEYWORDS (including UDF names) uppercase for readability
The text was updated successfully, but these errors were encountered:
Sadly this is the last name to be lowercase, others are already converted. I don't have strong preference on upper case or lower case as long as they are all consistent
Describe the bug
As a part of performing this change, @jayzhan211 recommended to use
min
andmax
as a default name for the new UDFs rather than the lowercase. However, performing this change makes test fails because in several places we use MAX and MIN, for example:https://github.com/apache/datafusion/blob/0332eb569a5428ac385fe892ce7b5fb40d52c8c0/datafusion/sqllogictest/test_files/tpch/q15.slt.part use MAX uppercase that would cause build failure when comparing LogicalPlan like in the following build:
https://github.com/apache/datafusion/actions/runs/10215600305/job/28265554129?pr=11013
In the rust tests as well we use
avg
butMAX
, so we need to update those tests as welldatafusion/datafusion/core/src/dataframe/mod.rs
Line 2059 in 0332eb5
To Reproduce
No response
Expected behavior
No response
Additional context
I have not verified if MAX and MIN are the only UDF for which we use uppercase rather than lowercase. I personally prefer to have all SQL KEYWORDS (including UDF names) uppercase for readability
The text was updated successfully, but these errors were encountered: