Fix plan_to_sql: Add wildcard projection to SELECT statement if no projection was set
#11744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LatrecheYasser
changed the title
LatrecheYasser
changed the title
LatrecheYasser
force-pushed
the
fix_table_scan_plan_to_sql_bug
branch
from
ca41671
to
ab59183
Compare
alamb
changed the title
plan_to_sql: Add wildcard projection to SELECT statement if no projection was set
alamb
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Thank you @LatrecheYasser -- this looks good to me. I started the CI checks and assuming they pass I think this PR is ready to go
|
https://github.com/apache/datafusion/actions/runs/10179108058/job/28167144185?pr=11744 is failing -- I think we can fix that by running |
thanks @alamb I will run the |
alamb
approved these changes
Jul 31, 2024
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11743.
Rationale for this change
This PR will check the
select_builderin theselect_to_sql_exprafter calling theselect_to_sql_recursivelyand if no projection is set, it will add a projection with one element set toast::SelectItem::Wildcard(ast::WildcardAdditionalOptions::default())What changes are included in this PR?
The changes described above, and some test cases.
Are these changes tested?
Yes.
Are there any user-facing changes?
I would say no.