Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AccumulatorArgs::is_reversed in NthValueAgg #11668

Closed
jcsherin opened this issue Jul 26, 2024 · 0 comments · Fixed by #11669
Closed

Use AccumulatorArgs::is_reversed in NthValueAgg #11668

jcsherin opened this issue Jul 26, 2024 · 0 comments · Fixed by #11669
Labels
enhancement New feature or request

Comments

@jcsherin
Copy link
Contributor

Is your feature request related to a problem or challenge?

The changes in #11564 introduced AccumulatorArgs::is_reversed. This indicates that the sort order of the aggregation is reversed.

The existing implementation of NthValueAgg tracks this as internal state. Instead of that use AccumulatorArgs::is_reversed.

Describe the solution you'd like

Refactor NthValueAgg to use AccumulatorArgs::is_reversed.

Describe alternatives you've considered

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use AccumulatorArgs::is_reversed in NthValueAgg jcsherin/datafusion
1 participant
@jcsherin