Update cache key used in rust CI script #11641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment is in `linux-build-lib` and refers to `linux-build-lib` as to some other thing.
github-actions
bot
added
the
development-process
alamb
reviewed
Jul 24, 2024
| @@ -62,8 +62,7 @@ jobs: | |||
| ~/.cargo/git/db/ | |||
| ./target/ | |||
| ./datafusion-cli/target/ | |||
There was a problem hiding this comment.
Seems ok to me -- how do we know if this improves things or not 🤔
|
Thanks @findepi |
|
can we have a description, what this PR is for? |
|
@comphead thanks for reminder, added |
technically none other than removing misleading comment & value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup of the GitHub workflow definition.