Unify CI and pre-commit hook settings for clippy #11640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit hook runs clippy and CI scripts run clippy too. The commands are and should be the same. Let's define them once.
alamb
approved these changes
Jul 24, 2024
| pushd datafusion-cli | ||
| cargo clippy --all-targets --all-features -- -D warnings | ||
| popd | ||
| ./ci/scripts/rust_clippy.sh |
There was a problem hiding this comment.
I also double checked that this is the same as used in CI:
datafusion/.github/workflows/rust.yml
Line 486 in bcf715c
👍
|
Thanks @findepi |
findepi
deleted the
findepi/unify-ci-and-pre-commit-hook-settings-for-clippy-ae3f47
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit hook runs clippy and CI scripts run clippy too. The commands are and should be the same. Let's define them once.