Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review code that downcast_ref from CatalogSession to SessionState #11600

Open
findepi opened this issue Jul 22, 2024 · 0 comments
Open

Review code that downcast_ref from CatalogSession to SessionState #11600

findepi opened this issue Jul 22, 2024 · 0 comments

Comments

@findepi
Copy link
Member

findepi commented Jul 22, 2024

#11516 added downcast_ref to SessionState in couple places with TODO comments. These places should be revised. Perhaps CatalogSession API should be extended so that downcast is not needed, or functionality refactored (e.g. as proposed here: #11516 (comment)).

Context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant