Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement evaluate_bounds for math unary functions #11583

Closed
tshauck opened this issue Jul 21, 2024 · 2 comments · Fixed by #11584
Closed

Implement evaluate_bounds for math unary functions #11583

tshauck opened this issue Jul 21, 2024 · 2 comments · Fixed by #11584
Assignees
Labels
enhancement New feature or request

Comments

@tshauck
Copy link
Contributor

tshauck commented Jul 21, 2024

Is your feature request related to a problem or challenge?

I noticed during #11559 that evaluate_bounds, which is used as part of determining a functions mononicity was not implemented so the trait default is used.

For many of these functions (e.g. cos) and more narrow set of bounds can be used.

Describe the solution you'd like

Update the unary math scalar function macro to take an evaluate bounds function, and implement that function where appropriate.

Describe alternatives you've considered

No response

Additional context

No response

@tshauck tshauck added the enhancement New feature or request label Jul 21, 2024
@tshauck
Copy link
Contributor Author

tshauck commented Jul 21, 2024

take

@alamb
Copy link
Contributor

alamb commented Jul 22, 2024

FYO @mustafasrepo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants