Rename ColumnOptions to ParquetColumnOptions
#11512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metesynnada or @metegenez I wonder if you have any thoughts about this change |
|
I dont see an issue here, ColumnOptions only belong to Parquet anyway. It is a good clarification. |
findepi
approved these changes
Jul 26, 2024
| @@ -1552,7 +1552,7 @@ config_namespace_with_hashmap! { | |||
| /// Options controlling parquet format for individual columns. | |||
| /// | |||
| /// See [`ParquetOptions`] for more details | |||
| pub struct ColumnOptions { | |||
| pub struct ParquetColumnOptions { | |||
There was a problem hiding this comment.
We could additionally (later) move the Parquet functionality to Parquet-related modules/files.
Perhaps just for organizational purposes.
jonahgao
approved these changes
Jul 27, 2024
|
Thanks @findepi and @jonahgao and @metegenez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11367
Rationale for this change
While reviewing #11444 from @wiedld I was somewhat confused about ColumnOptions were and that they were parquet specific
What changes are included in this PR?
ColumnOptionstoParquetColumnOptionsrust structsAre these changes tested?
Are there any user-facing changes?