Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sql_compound_identifier_to_expr to ExprPlanner #11473

Closed
Tracked by #11207
alamb opened this issue Jul 15, 2024 · 8 comments
Closed
Tracked by #11207

Move sql_compound_identifier_to_expr to ExprPlanner #11473

alamb opened this issue Jul 15, 2024 · 8 comments
Assignees

Comments

@alamb
Copy link
Contributor

alamb commented Jul 15, 2024

Is your feature request related to a problem or challenge?

Part of #11207

As discussed in #11207 The idea is to move hardcoded the sql_compound_identifier_to_expr operator to function in the parser step, which is currently handled in the optimizer step. We need to implement user-defined parser mechanisms to enable more flexible SQL planning.

Describe the solution you'd like

No response

Describe alternatives you've considered

I think you can just follow the model of #11398 and add a function to ExprPlanner and then update the sql planner to call it instead of get_functon_meta

Additional context

No response

@dharanad
Copy link
Contributor

seems like a duplicate of #11244
i will close and we can keep this open

@dharanad
Copy link
Contributor

take

@alamb
Copy link
Contributor Author

alamb commented Jul 15, 2024

Sorry @dharanad -- I didn't see #11244 before

@alamb alamb changed the title sql_compound_identifier_to_expr Move sql_compound_identifier_to_expr to ExprPlanner Jul 15, 2024
@dharanad
Copy link
Contributor

Sorry @dharanad -- I didn't see #11244 before

No worries at all.

@dharanad
Copy link
Contributor

QQ: @alamb In sql_compound_identifier_to_expr the only this which is using get_function_meta is get_field ScalarUDF. I think ideally we should move get_field to ExprPlanner. Rest of code as dependecy on SqlToRel struct

@alamb
Copy link
Contributor Author

alamb commented Jul 16, 2024

I think ideally we should move get_field to ExprPlanner. Rest of code as dependecy on SqlToRel struct

Makes sense to me 👍

@alamb
Copy link
Contributor Author

alamb commented Jul 21, 2024

After #11487 I wonder if there is anythng left for this item?

@jayzhan211
Copy link
Contributor

I think we are done with this item

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants