Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate SQL expr planners so there are one in each module (like a UnicodePlanner rather than a PositionPlanner? #11305

Closed
Tracked by #11207
alamb opened this issue Jul 6, 2024 · 0 comments · Fixed by #11318
Closed
Tracked by #11207

Consolidate SQL expr planners so there are one in each module (like a UnicodePlanner rather than a PositionPlanner? #11305

alamb opened this issue Jul 6, 2024 · 0 comments · Fixed by #11318

Comments

@alamb
Copy link
Contributor

alamb commented Jul 6, 2024 

          @jayzhan211  do you suggest we have one planner for each module (like a `UnicodePlanner` rather than a `PositionPlanner`?

I think this is similar to what you are proposing with CoreFunctionsPlanner in #11273 (comment) in #11273

We could make this change in a follow on PR too

Originally posted by @alamb in #11243 (comment)
@alamb alamb changed the title @jayzhan211 do you suggest we have one planner for each module (like a UnicodePlanner rather than a PositionPlanner? Consolidate SQL expr planners so there are one in each module (like a UnicodePlanner rather than a PositionPlanner? Jul 6, 2024
This was referenced Jul 6, 2024
Closed
Merged
@xinlifoobar xinlifoobar mentioned this issue Jul 7, 2024
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made UserDefinedFunctionPlanner to uniform the usages xinlifoobar/datafusion
1 participant
@alamb