Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce test duplication in tests for data page stattistics #11000

Closed
Tracked by #10922
alamb opened this issue Jun 19, 2024 · 1 comment · Fixed by #11479
Closed
Tracked by #10922

Reduce test duplication in tests for data page stattistics #11000

alamb opened this issue Jun 19, 2024 · 1 comment · Fixed by #11479
Assignees

Comments

@alamb
Copy link
Contributor

alamb commented Jun 19, 2024

Follow on to #10982

@tshauck noted there is non trivial repetition in some tests

@tmi says:

@tshauck this is one of the things that were bugging me a bit, the other one being https://github.com/apache/datafusion/pull/10982/files#diff-7110f4709c105a18ef74a212396444d62052179a735d148fb62470a8b157fb40R749-R763 -- both are very repetitive

however, I didn't want to get overeager, only to realize later than the abstractions chosen was not the right one. Perhaps the best way forward would be to address #10952 first (which may also have its own "float16"-like tricky case), and then getting the correct macros for testing, index handling, etc. Speaking of that, would you like to take that one? I'd be happy to review then

Originally posted by @tmi in #10982 (comment)

@alamb
Copy link
Contributor Author

alamb commented Jul 8, 2024

I propose we consolidate / review the tests when we move this code upstream: apache/arrow-rs#4328

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant