Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid cloning when simplifying expressions for Log, Power UDF #10003

Closed
tinfoil-knight opened this issue Apr 8, 2024 · 2 comments · Fixed by #10086
Closed

Avoid cloning when simplifying expressions for Log, Power UDF #10003

tinfoil-knight opened this issue Apr 8, 2024 · 2 comments · Fixed by #10086
Assignees
@tinfoil-knight
Labels
enhancement New feature or request

Comments

@tinfoil-knight
Copy link
Contributor

tinfoil-knight commented Apr 8, 2024 •
edited
Loading

Is your feature request related to a problem or challenge?

@alamb pointed this out while reviewing #9983

https://github.com/apache/arrow-datafusion/blob/ad0abe91752b8da327e97b09d8ca883c782f027d/datafusion/functions/src/math/log.rs#L179

It would be really nice to avoid this clone (I am working to reduce the number of times we need to clone Exprs during planning). see tinfoil-knight#1 for a suggestion

See #9983 (comment)

Describe the solution you'd like

Avoid using .clone() wherever possible

Describe alternatives you've considered

No response

Additional context

No response
@tinfoil-knight tinfoil-knight added the enhancement New feature or request label Apr 8, 2024
@tinfoil-knight
Copy link
Contributor Author

take

@alamb alamb mentioned this issue Apr 15, 2024
Merged
@alamb
Copy link
Contributor

alamb commented Apr 15, 2024

I polished up some code I had and put it up as #10086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinfoil-knight tinfoil-knight

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid cloning in log::simplify and power::simplify alamb/datafusion
2 participants
@alamb @tinfoil-knight