Skip to content

Commit feaa790

Browse files
alambalamb
committed
tweak
1 parent d317005 commit feaa790

File tree

1 file changed

+40
-30
lines changed

1 file changed

+40
-30
lines changed

‎.github/workflows/rust.yml‎

Lines changed: 40 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -108,14 +108,17 @@ jobs:
108108
run: cargo check --profile ci --all-targets -p datafusion-substrait
109109
- name: Check datafusion-substrait (no-default-features)
110110
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-substrait
111+
#
112+
# Note: Only check libraries (not --all-targets) to cover end user APIs
113+
#
111114
- name: Check datafusion-substrait (physical)
112-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-substrait --features=physical
115+
run: cargo check --profile ci --no-default-features -p datafusion-substrait --features=physical
113116
- name: Install cmake
114117
run: |
115118
# note the builder setup runs apt-get update / installs protobuf compiler
116119
apt-get install -y cmake
117120
- name: Check datafusion-substrait (protoc)
118-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-substrait --features=protoc
121+
run: cargo check --profile ci --no-default-features -p datafusion-substrait --features=protoc
119122

120123
# Check datafusion-proto features
121124
#
@@ -135,15 +138,18 @@ jobs:
135138
rust-version: stable
136139
- name: Check datafusion-proto (default features)
137140
run: cargo check --profile ci --all-targets -p datafusion-proto
141+
#
142+
# Note: Only check libraries (not --all-targets) to cover end user APIs
143+
#
138144
- name: Check datafusion-proto (no-default-features)
139-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion
145+
run: cargo check --profile ci --no-default-features -p datafusion
140146
# fails due to https://github.com/apache/datafusion/issues/15157
141147
#- name: Check datafusion-proto (json)
142148
# run: cargo check --profile ci --no-default-features -p datafusion-proto --features=json
143149
- name: Check datafusion-proto (parquet)
144-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-proto --features=parquet
150+
run: cargo check --profile ci --no-default-features -p datafusion-proto --features=parquet
145151
- name: Check datafusion-proto (avro)
146-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-proto --features=avro
152+
run: cargo check --profile ci --no-default-features -p datafusion-proto --features=avro
147153

148154

149155
# Check datafusion crate features
@@ -169,40 +175,41 @@ jobs:
169175
# https://github.com/apache/datafusion/issues/15208
170176
#run: cargo check --profile ci --all-targets --no-default-features -p datafusion
171177
run: cargo check --profile ci --no-default-features -p datafusion
178+
# Note: Only check libraries (not --all-targets) to cover end user APIs
172179
- name: Check datafusion (nested_expressions)
173-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=nested_expressions
180+
run: cargo check --profile ci --no-default-features -p datafusion --features=nested_expressions
174181
- name: Check datafusion (array_expressions)
175-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=array_expressions
182+
run: cargo check --profile ci --no-default-features -p datafusion --features=array_expressions
176183
- name: Check datafusion (avro)
177-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=avro
184+
run: cargo check --profile ci --no-default-features -p datafusion --features=avro
178185
- name: Check datafusion (backtrace)
179-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=backtrace
186+
run: cargo check --profile ci --no-default-features -p datafusion --features=backtrace
180187
- name: Check datafusion (compression)
181-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=compression
188+
run: cargo check --profile ci --no-default-features -p datafusion --features=compression
182189
- name: Check datafusion (crypto_expressions)
183-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=crypto_expressions
190+
run: cargo check --profile ci --no-default-features -p datafusion --features=crypto_expressions
184191
- name: Check datafusion (datetime_expressions)
185-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=datetime_expressions
192+
run: cargo check --profile ci --no-default-features -p datafusion --features=datetime_expressions
186193
- name: Check datafusion (encoding_expressions)
187-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=encoding_expressions
194+
run: cargo check --profile ci --no-default-features -p datafusion --features=encoding_expressions
188195
- name: Check datafusion (force_hash_collisions)
189-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=force_hash_collisions
196+
run: cargo check --profile ci --no-default-features -p datafusion --features=force_hash_collisions
190197
- name: Check datafusion (math_expressions)
191-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=math_expressions
198+
run: cargo check --profile ci --no-default-features -p datafusion --features=math_expressions
192199
- name: Check datafusion (parquet)
193-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=parquet
200+
run: cargo check --profile ci --no-default-features -p datafusion --features=parquet
194201
- name: Check datafusion (pyarrow)
195-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=pyarrow
202+
run: cargo check --profile ci --no-default-features -p datafusion --features=pyarrow
196203
- name: Check datafusion (regex_expressions)
197-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=regex_expressions
204+
run: cargo check --profile ci --no-default-features -p datafusion --features=regex_expressions
198205
- name: Check datafusion (recursive_protection)
199-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=recursive_protection
206+
run: cargo check --profile ci --no-default-features -p datafusion --features=recursive_protection
200207
- name: Check datafusion (serde)
201-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=serde
208+
run: cargo check --profile ci --no-default-features -p datafusion --features=serde
202209
- name: Check datafusion (string_expressions)
203-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=string_expressions
210+
run: cargo check --profile ci --no-default-features -p datafusion --features=string_expressions
204211
- name: Check datafusion (unicode_expressions)
205-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion --features=unicode_expressions
212+
run: cargo check --profile ci --no-default-features -p datafusion --features=unicode_expressions
206213

207214
# Check datafusion-functions crate features
208215
#
@@ -226,21 +233,24 @@ jobs:
226233
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-functions
227234
# Fails due https://github.com/apache/datafusion/issues/15207
228235
#- name: Check datafusion-functions (core_expressions)
229-
# run: cargo check --profile ci --all-targets --no-default-features -p datafusion-functions --features=core_expressions
236+
# run: cargo check --profile ci --no-default-features -p datafusion-functions --features=core_expressions
237+
#
238+
# Note: Only check libraries (not --all-targets) to cover end user APIs
239+
#
230240
- name: Check datafusion-functions (crypto_expressions)
231-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-functions --features=crypto_expressions
241+
run: cargo check --profile ci --no-default-features -p datafusion-functions --features=crypto_expressions
232242
- name: Check datafusion-functions (datetime_expressions)
233-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-functions --features=datetime_expressions
243+
run: cargo check --profile ci --no-default-features -p datafusion-functions --features=datetime_expressions
234244
- name: Check datafusion-functions (encoding_expressions)
235-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-functions --features=encoding_expressions
245+
run: cargo check --profile ci --no-default-features -p datafusion-functions --features=encoding_expressions
236246
- name: Check datafusion-functions (math_expressions)
237-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-functions --features=math_expressions
247+
run: cargo check --profile ci --no-default-features -p datafusion-functions --features=math_expressions
238248
- name: Check datafusion-functions (regex_expressions)
239-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-functions --features=regex_expressions
249+
run: cargo check --profile ci --no-default-features -p datafusion-functions --features=regex_expressions
240250
- name: Check datafusion-functions (string_expressions)
241-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-functions --features=string_expressions
251+
run: cargo check --profile ci --no-default-features -p datafusion-functions --features=string_expressions
242252
- name: Check datafusion-functions (unicode_expressions)
243-
run: cargo check --profile ci --all-targets --no-default-features -p datafusion-functions --features=unicode_expressions
253+
run: cargo check --profile ci --no-default-features -p datafusion-functions --features=unicode_expressions
244254

245255
# Run tests
246256
linux-test:

0 commit comments

Comments
 (0)