feat: Support ANSI mode sum expr (int inputs) #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Dec 23, 2025

docs/source/user-guide/latest/compatibility.md

-Original file line number
+Diff line change
@@ Expand Up @@
     ## ANSI Mode
-    Comet will fall back to Spark for the following expressions when ANSI mode is enabled. Thes expressions can be enabled by setting
+    Comet will fall back to Spark for the following expressions when ANSI mode is enabled. These expressions can be enabled by setting
     `spark.comet.expression.EXPRNAME.allowIncompatible=true`, where `EXPRNAME` is the Spark expression class name. See
     the [Comet Supported Expressions Guide](expressions.md) for more information on this configuration setting.
     - Average
-    - Sum
     - Cast (in some cases)
     There is an [epic](https://github.com/apache/datafusion-comet/issues/313) where we are tracking the work to fully implement ANSI support.
@@ Expand Down @@

native/core/src/execution/planner.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -71,6 +71,7 @@ use datafusion::{ @@
     use datafusion_comet_spark_expr::{
         create_comet_physical_fun, create_comet_physical_fun_with_eval_mode, BinaryOutputStyle,
         BloomFilterAgg, BloomFilterMightContain, EvalMode, SparkHour, SparkMinute, SparkSecond,
+        SumInteger,
     };
     use iceberg::expr::Bind;
@@ Expand Down Expand Up / @@ -1813,6 +1814,12 @@ impl PhysicalPlanner { @@
                                 AggregateUDF::new_from_impl(SumDecimal::try_new(datatype, eval_mode)?);
                             AggregateExprBuilder::new(Arc::new(func), vec![child])
                         }
+                        DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 => {
+                            let eval_mode = from_protobuf_eval_mode(expr.eval_mode)?;
+                            let func =
+                                AggregateUDF::new_from_impl(SumInteger::try_new(datatype, eval_mode)?);
+                            AggregateExprBuilder::new(Arc::new(func), vec![child])
+                        }
                         _ => {
                             // cast to the result data type of SUM if necessary, we should not expect
                             // a cast failure since it should have already been checked at Spark side
@@ Expand Down @@

native/spark-expr/src/agg_funcs/mod.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -21,6 +21,7 @@ mod correlation; @@
     mod covariance;
     mod stddev;
     mod sum_decimal;
+    mod sum_int;
     mod variance;
     pub use avg::Avg;
@@ Expand All / @@ -29,4 +30,5 @@ pub use correlation::Correlation; @@
     pub use covariance::Covariance;
     pub use stddev::Stddev;
     pub use sum_decimal::SumDecimal;
+    pub use sum_int::SumInteger;
     pub use variance::Variance;

Provide feedback