-
Notifications
You must be signed in to change notification settings - Fork 253
build: Stop running Comet's Spark 4 tests on Linux for PR builds #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can we make the Spark 4 pipeline available as a manually triggered pipeline? We do need to make sure we are more or less stable wrt Spark 4. |
Sure. I moved it to a separate workflow for now. We are still running Spark 4 tests on macos. |
parthchandra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
comphead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @andygrove
|
It is also worth noting that we are still running the Spark SQL tests for Spark 4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
============================================
+ Coverage 56.12% 59.45% +3.32%
- Complexity 976 1147 +171
============================================
Files 119 128 +9
Lines 11743 12528 +785
Branches 2251 2355 +104
============================================
+ Hits 6591 7448 +857
+ Misses 4012 3889 -123
- Partials 1140 1191 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Which issue does this PR close?
Part of #1786
Rationale for this change
Until we resolve #1786, let's stop running the problematic test so that we can unblock other PRs.
We are still testing Spark 4 on macos.
What changes are included in this PR?
How are these changes tested?