Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented May 22, 2025

Which issue does this PR close?

N/A

Rationale for this change

I am trying to help debug a test failure with AQE + DPP and it is hard to understand what is going on just by stepping through code given the recursive nature of planning in AQE. Some logging should help.

Example:

25/05/22 16:36:37.402 ScalaTest-run-running-CometExpressionSuite INFO CometScanRule: 
INPUT: Project [md5(cast(col#23 as binary)) AS md5(col)#34]
+- FileScan parquet spark_catalog.default.test[col#23] Batched: true, DataFilters: [], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/home/andy/git/apache/datafusion-comet/spark-warehouse/test], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<col:string>

OUTPUT: Project [md5(cast(col#23 as binary)) AS md5(col)#34]
+- CometScan parquet spark_catalog.default.test[col#23] Batched: true, DataFilters: [], Format: CometParquet, Location: InMemoryFileIndex(1 paths)[file:/home/andy/git/apache/datafusion-comet/spark-warehouse/test], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<col:string>

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2025

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.56%. Comparing base (f09f8af) to head (2d0a7b1).
Report is 207 commits behind head on main.

Files with missing lines Patch % Lines
...n/scala/org/apache/comet/rules/CometExecRule.scala 40.00% 1 Missing and 2 partials ⚠️
...n/scala/org/apache/comet/rules/CometScanRule.scala 40.00% 1 Missing and 2 partials ⚠️
...he/comet/rules/EliminateRedundantTransitions.scala 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1780      +/-   ##
============================================
+ Coverage     56.12%   58.56%   +2.43%     
- Complexity      976     1146     +170     
============================================
  Files           119      130      +11     
  Lines         11743    12686     +943     
  Branches       2251     2366     +115     
============================================
+ Hits           6591     7429     +838     
- Misses         4012     4066      +54     
- Partials       1140     1191      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove merged commit 042104b into apache:main May 23, 2025
83 checks passed
@andygrove andygrove deleted the log-in-rules branch May 23, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants