Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark/Light mode splashscreens #246

Closed
globules-io opened this issue Feb 5, 2020 · 4 comments
Closed

Dark/Light mode splashscreens #246

globules-io opened this issue Feb 5, 2020 · 4 comments

Comments

@globules-io
Copy link

Feature Request

Feature Description

Would be nice to have 2 sets of splash screens depending on the current mode (dark vs light) so they actually match with the app UI.

@timbru31
Copy link
Member

timbru31 commented Feb 5, 2020

Is this even supported on the native side (especially iOS)?

@globules-io
Copy link
Author

Yes you can check if the current theme is dark or light and support comes with iOS13.
Android support start at 9 (API level 28).

@breautek
Copy link
Contributor

breautek commented Feb 6, 2020

For iOS, it looks like assets can be assigned to any appearance, or just light, or just dark. https://developer.apple.com/documentation/xcode/supporting_dark_mode_in_your_interface?changes=latest_minor

On Android, dark theme is actually only available on API 29, which will be the new default and officially supported in cordova-android 9 (not currently released). It looks to be configurable by using a -night qualifier on the drawables. This SO I think makes it easier to understand what android needs compared to reading the official docs.

https://developer.android.com/guide/topics/ui/look-and-feel/darktheme

Just providing helpful links for anybody willing to tackle this.

@EinfachHans
Copy link
Contributor

Just to let you know: I think this Issue can be closed now. For iOS this works since cordova-ios6.1.0. I just tested around with Android this works kind of out of the Box as well. Just adding -night on the right Place to the density works (Also with NightMode on my Android 9 Device).
I will create a PR to add this Info to the Readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants