Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin is not correctly installed if the package contains "app" #571

Closed
jcesarmobile opened this issue Nov 22, 2018 · 3 comments
Closed

Plugin is not correctly installed if the package contains "app" #571

jcesarmobile opened this issue Nov 22, 2018 · 3 comments

Comments

@jcesarmobile
Copy link
Member

jcesarmobile commented Nov 22, 2018 •
edited
Loading

Example from cordova-plugin-local-notifications https://github.com/katzer/cordova-plugin-local-notifications
src/de/appplant/cordova/plugin/localnotification

We should probably check for "app/", but might still affect others. Maybe use startsWith instead of includes?
@jcesarmobile jcesarmobile mentioned this issue Nov 22, 2018
Closed
@brodycj brodycj mentioned this issue Nov 22, 2018
Merged
@brodycj
Copy link
Contributor

brodycj commented Nov 22, 2018

cordova-plugin-inappbrowser is also affected, thanks to @kamilbrk for pointing it out in #572 (comment)

@brodycj
Copy link
Contributor

brodycj commented Nov 22, 2018

Will be in cordova-android@nightly (nightly build from master branch, with bleeding-edge updates for Cordova 9) in 12-24 hours or so, patch release coming in the next few days.

@brodycj brodycj mentioned this issue Nov 22, 2018
Closed
@brodycj
Copy link
Contributor

brodycj commented Nov 23, 2018

7.1.4 patch release is now published to resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brodycj @jcesarmobile